Add animal-sniffer to guard against Java 8 only APIs#264
Merged
ZacSweers merged 3 commits intouber:masterfrom Oct 14, 2018
Merged
Add animal-sniffer to guard against Java 8 only APIs#264ZacSweers merged 3 commits intouber:masterfrom
ZacSweers merged 3 commits intouber:masterfrom
Conversation
Signed-off-by: shaishavgandhi05 <shaishgandhi@gmail.com>
Collaborator
|
We do to need to configure which java version? |
Collaborator
Author
|
It's here I've added it as 1.7 since my understanding was that animal-sniffer will check if it compiles to Java 1.7. Since we don't want any Java8-only APIs, 1.7 would work. |
Collaborator
|
Ah gotcha, missed that on the first read. Could we try a sample commit in this branch to confirm it fails the CI checks? Then we can revert the commit after and merge if it works as expected 👍 |
Signed-off-by: shaishavgandhi05 <shaishgandhi@gmail.com>
Collaborator
Author
|
Pushed a commit that fails the check. Let me know if it looks good and I can revert it. |
Collaborator
|
Perfect! Looks good, let’s revert and we can merge |
This reverts commit 2118729.
Collaborator
Author
|
Done! |
ShaishavGandhi
added a commit
that referenced
this pull request
Mar 18, 2019
I was looking at integrating Animal Sniffer elsewhere and I found that the integration in AutoDispose was non-existent. In #264, I added a Java 8 API to show that Animal Sniffer works. Then when I was supposed to revert the Java 8 API commit, I reverted actual animal sniffer integration.  So now, this build will fail because the Java 8 API is still existent (it didn't harm anyone since it was only a test that wasn't used by anyone). I'll remove it once this build fails on CI.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description: Add animal-sniffer to guard against Java 8 only APIs
Resolves #261